Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include pool size in database.yml.erb #99

Closed
wants to merge 1 commit into from
Closed

Include pool size in database.yml.erb #99

wants to merge 1 commit into from

Conversation

bartimaeus
Copy link

We need pool size in the database.yml.erb otherwise we run out of database connections when scaling.

@jbraeuer
Copy link
Contributor

jbraeuer commented Feb 2, 2014

Thanks for your pull request. A change that adds support for pool size is currently on it's way to production. So consider this issue to be fixed soon.

The commit also adds support for wait_timeout. Do you require this? Searching for mysql2 and wait_timeout suggests it's use has some pitfalls. See
rails/rails#6441
rails/rails#7684

@bartimaeus
Copy link
Author

I'm okay without wait_timeout. pool size is the must have. Thanks!

@jbraeuer
Copy link
Contributor

jbraeuer commented Feb 4, 2014

Ok, then I will close this issue as pool size is currently on it's way to prod.

@jbraeuer jbraeuer closed this Feb 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartimaeus @jbraeuer